Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(algebra/big_operators): add commute.*_sum_{left,right} lemmas #13035

Closed
wants to merge 4 commits into from

Conversation

eric-wieser
Copy link
Member

This moves the existing prod_commute lemmas into the commute namespace for discoverabiliy, and adds the swapped variants.

This also fixes an issue where lemmas about add_commute were misnamed using commute.


Open in Gitpod

These live in their respective namespaces for now to match `list.prod_commute` and `multiset.prod_commute`.

This also renames the existing additive versions to `sum_add_commute`, to avoid confusion.
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

bors r+

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Apr 4, 2022
bors bot pushed a commit that referenced this pull request Apr 4, 2022
…13035)

This moves the existing `prod_commute` lemmas into the `commute` namespace for discoverabiliy, and adds the swapped variants.

This also fixes an issue where lemmas about `add_commute` were misnamed using `commute`.
@bors
Copy link

bors bot commented Apr 4, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(algebra/big_operators): add commute.*_sum_{left,right} lemmas [Merged by Bors] - feat(algebra/big_operators): add commute.*_sum_{left,right} lemmas Apr 4, 2022
@bors bors bot closed this Apr 4, 2022
@bors bors bot deleted the eric-wieser/sum_commute branch April 4, 2022 11:22
jjaassoonn pushed a commit that referenced this pull request Apr 7, 2022
…13035)

This moves the existing `prod_commute` lemmas into the `commute` namespace for discoverabiliy, and adds the swapped variants.

This also fixes an issue where lemmas about `add_commute` were misnamed using `commute`.
jjaassoonn pushed a commit that referenced this pull request Apr 7, 2022
…13035)

This moves the existing `prod_commute` lemmas into the `commute` namespace for discoverabiliy, and adds the swapped variants.

This also fixes an issue where lemmas about `add_commute` were misnamed using `commute`.
jjaassoonn pushed a commit that referenced this pull request Apr 7, 2022
…13035)

This moves the existing `prod_commute` lemmas into the `commute` namespace for discoverabiliy, and adds the swapped variants.

This also fixes an issue where lemmas about `add_commute` were misnamed using `commute`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants