Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(ring_theory/localization): b is linear independent over R iff l.i. over Frac(R) #13041

Closed
wants to merge 6 commits into from

Conversation

Vierkantor
Copy link
Collaborator

Co-authored-by: Junyan Xu junyanxumath@gmail.com


Open in Gitpod

@Vierkantor Vierkantor added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Mar 29, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Mar 29, 2022
@riccardobrasca
Copy link
Member

If it is not too much work for this PR can you add a def to promote b : basis ι R M to basis ι K M? Thanks!

@Vierkantor
Copy link
Collaborator Author

Vierkantor commented Apr 1, 2022

If it is not too much work for this PR can you add a def to promote b : basis ι R M to basis ι K M? Thanks!

Sure, if you can wait till after the weekend: have a few other things to finish today :)

variables {M : Type*} [add_comm_group M] [module R M] [module Rₛ M] [is_scalar_tower R Rₛ M]

/-- Promote a basis for `M` over `R` to a basis for `M` over the localization `Rₛ` -/
noncomputable def basis.localization {ι : Type*} (b : basis ι R M) : basis ι Rₛ M :=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add it to ## Main results? Thanks!

bors d+

@bors
Copy link

bors bot commented Apr 4, 2022

✌️ Vierkantor can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@Vierkantor Vierkantor added delegated The PR author may merge after reviewing final suggestions. ready-for-bors and removed awaiting-review The author would like community review of the PR labels Apr 4, 2022
@Vierkantor
Copy link
Collaborator Author

Build failure was transient, so:

bors r+

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Apr 8, 2022
bors bot pushed a commit that referenced this pull request Apr 8, 2022
…i. over `Frac(R)` (#13041)

Co-authored-by: Junyan Xu <junyanxumath@gmail.com>



Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
@bors
Copy link

bors bot commented Apr 8, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(ring_theory/localization): b is linear independent over R iff l.i. over Frac(R) [Merged by Bors] - feat(ring_theory/localization): b is linear independent over R iff l.i. over Frac(R) Apr 8, 2022
@bors bors bot closed this Apr 8, 2022
@bors bors bot deleted the linear_independent-localization branch April 8, 2022 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. ready-for-bors ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants