Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(ring_theory/valuation/basic): fix valuation_apply #13045

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - chore(ring_theory/valuation/basic): fix valuation_apply #13045

wants to merge 1 commit into from

Conversation

mariainesdff
Copy link
Collaborator

Follow-up to #12914.

Open in Gitpod

@mariainesdff mariainesdff added the awaiting-review The author would like community review of the PR label Mar 29, 2022
eric-wieser
eric-wieser approved these changes Mar 29, 2022
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

@bors
Copy link

bors bot commented Mar 29, 2022

✌️ mariainesdff can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Mar 29, 2022
@eric-wieser
Copy link
Member

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Mar 29, 2022
bors bot pushed a commit that referenced this pull request Mar 29, 2022
@mariainesdff
chore(ring_theory/valuation/basic): fix valuation_apply (#13045)
119eb05 
Follow-up to #12914.
@bors
Copy link

bors bot commented Mar 29, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(ring_theory/valuation/basic): fix valuation_apply [Merged by Bors] - chore(ring_theory/valuation/basic): fix valuation_apply Mar 29, 2022
@bors bors bot closed this Mar 29, 2022
@bors bors bot deleted the valuation_apply branch March 29, 2022 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mariainesdff @eric-wieser @leanprover-community-bot-assistant