Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - split(order/chain): Split off order.zorn #13060

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - split(order/chain): Split off order.zorn #13060

wants to merge 2 commits into from

Conversation

YaelDillies
Copy link
Collaborator

@YaelDillies YaelDillies commented Mar 30, 2022 •
edited

Split order.zorn into two files, one about chains, the other one about Zorn's lemma.

The goal is to then add the types of chains and flags to order.chain.

Open in Gitpod

@YaelDillies YaelDillies added the awaiting-review The author would like community review of the PR label Mar 30, 2022
@semorrison semorrison added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Mar 31, 2022
@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Mar 31, 2022
bryangingechen
bryangingechen approved these changes Mar 31, 2022
View reviewed changes
Copy link
Collaborator

@bryangingechen bryangingechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
bors r+

bors bot pushed a commit that referenced this pull request Mar 31, 2022
@YaelDillies
split(order/chain): Split off order.zorn (#13060)
de50389 
Split `order.zorn` into two files, one about chains, the other one about Zorn's lemma.
@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Mar 31, 2022
@bors
Copy link

bors bot commented Mar 31, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title split(order/chain): Split off order.zorn [Merged by Bors] - split(order/chain): Split off order.zorn Mar 31, 2022
@bors bors bot closed this Mar 31, 2022
@bors bors bot deleted the split_zorn branch March 31, 2022 18:50
jjaassoonn pushed a commit that referenced this pull request Apr 7, 2022
@YaelDillies @jjaassoonn
split(order/chain): Split off order.zorn (#13060)
1835b3b 
Split `order.zorn` into two files, one about chains, the other one about Zorn's lemma.
jjaassoonn pushed a commit that referenced this pull request Apr 7, 2022
@YaelDillies @jjaassoonn
split(order/chain): Split off order.zorn (#13060)
222e837 
Split `order.zorn` into two files, one about chains, the other one about Zorn's lemma.
jjaassoonn pushed a commit that referenced this pull request Apr 7, 2022
@YaelDillies @jjaassoonn
split(order/chain): Split off order.zorn (#13060)
2d9230b 
Split `order.zorn` into two files, one about chains, the other one about Zorn's lemma.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryangingechen bryangingechen bryangingechen approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@YaelDillies @bryangingechen @semorrison @leanprover-community-bot-assistant