Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(combinatorics/stars_and_bars): Add a dedicated type for stars and bars #13063

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Mar 30, 2022


Open in Gitpod

@eric-wieser eric-wieser added the awaiting-review The author would like community review of the PR label Mar 30, 2022
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Mar 30, 2022
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Mar 30, 2022
@robertylewis
Copy link
Member

@eric-wieser , is this file meant as a standalone "leaf node," or do you forsee uses for it in other developments? I'll admit, I've always thought of "stars and bars" as just a thing that can be counted with binomial coefficients, not as a data structure itself. So I'm wondering about the motivation for this new file.

@eric-wieser
Copy link
Member Author

I've seen a bunch of cardinality arguments that just say "well this type is isomorphic to stars and bars in some obvious way, so the cardinality is the same". For such an argument to be visible in the lean code, we presumably need some stars_and_bars type.

I'll change this back to awaiting author though, since it probably does make sense to add the particular cardinality argument I had in mind, which is waiting on me to cleanup another PR.

@eric-wieser eric-wieser added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Apr 8, 2022
@YaelDillies
Copy link
Collaborator

What's the status of this?

@semorrison semorrison added the too-late This PR was ready too late for inclusion in mathlib3 label Jul 16, 2023
@eric-wieser eric-wieser requested a review from a team as a code owner October 16, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-author A reviewer has asked the author a question or requested changes too-late This PR was ready too late for inclusion in mathlib3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants