chore(category_theory/isomorphism): docstring, DRY, add some trivial lemmas #1309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lemmas - add module docstring; - use `as_iso` more aggressively to avoid repeating proofs; - add more trivial lemmas.
|
I needed some of the new lemmas for another PR I'm working on. Decided to split this into a dedicated PR to simplify review. |
|
Looks uncontroversial to me. Lots of good cleanup, and a good module doc at the top! |
|
What does DRY in the title stand for? |
|
don't repeat yourself, a.k.a extracting common code/lemmas |
robertylewis
approved these changes
Aug 15, 2019
robertylewis
added
the
ready-to-merge
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 15, 2020
…lemmas (leanprover-community#1309) - add module docstring; - use `as_iso` more aggressively to avoid repeating proofs; - add more trivial lemmas.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as_isomore aggressively to avoid repeating proofs;TO CONTRIBUTORS:
Make sure you have:
If this PR is related to a discussion on Zulip, please include a link in the discussion.
For reviewers: code review check list