[Merged by Bors] - fix(data/polynomial/basic): op_ring_equiv docstring #13132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kbuzzard
commented
Apr 2, 2022
kbuzzard
commented
kbuzzard
added
easy
eric-wieser
reviewed
Apr 2, 2022
src/data/polynomial/basic.lean
Outdated
| @@ -173,7 +173,7 @@ def to_finsupp_iso : R[X] ≃+* add_monoid_algebra R ℕ := | |||
| map_mul' := by { rintros ⟨⟩ ⟨⟩, simp [mul_to_finsupp] }, | |||
| map_add' := by { rintros ⟨⟩ ⟨⟩, simp [add_to_finsupp] } } | |||
|
|
|||
| /-- Ring isomorphism between `R[X]ᵐᵒᵖ` and `R[X]ᵐᵒᵖ`. -/ | |||
| /-- Ring isomorphism between `R[X]ᵐᵒᵖ` and `Rᵐᵒᵖ[X]`. -/ | |||
There was a problem hiding this comment.
Maybe we should rewrite this entirely
Suggested change
| /-- Ring isomorphism between `R[X]ᵐᵒᵖ` and `Rᵐᵒᵖ[X]`. -/ | |
| /-- Ring isomorphism sending each coefficient of a polynomial to the opposite ring. -/ |
The currently version is just an explanation of what ≃+* means, which is silly.
|
✌️ kbuzzard can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-bot-assistant
added
delegated
|
bors merge |
github-actions
bot
added
the
ready-to-merge
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
jjaassoonn
pushed a commit
that referenced
this pull request
Apr 7, 2022
jjaassoonn
pushed a commit
that referenced
this pull request
Apr 7, 2022
jjaassoonn
pushed a commit
that referenced
this pull request
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.