Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - refactor(analysis/complex): replace diff_on_int_cont with diff_cont_on_cl #13148

Closed
wants to merge 4 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Apr 3, 2022

Use "differentiable on a set and continuous on its closure" instead of "continuous on a set and differentiable on its interior".
There are a few reasons to prefer the latter:

  • it has better "composition" lemma;
  • it allows us to talk about functions that are, e.g., differentiable on {z : ℂ | abs z < 1 ∧ (re z < 0 ∨ im z ≠ 0)} and continuous on the closed unit disk.

Also generalize eq_on_of_eq_on_frontier from a compact set to a bounded set (so that it works, e.g., for the unit ball in a Banach space).

This PR does not move the file diff_on_int_cont to make the diff more readable; the file will be moved in another PR.


  • fix docstrings: in progress

Open in Gitpod

@urkud urkud added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Apr 3, 2022
@urkud urkud requested a review from sgouezel April 3, 2022 04:53
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Apr 3, 2022
@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Apr 9, 2022
bors bot pushed a commit that referenced this pull request Apr 9, 2022
…t_on_cl` (#13148)

Use "differentiable on a set and continuous on its closure" instead of "continuous on a set and differentiable on its interior".
There are a few reasons to prefer the latter:

* it has better "composition" lemma;
* it allows us to talk about functions that are, e.g., differentiable on `{z : ℂ | abs z < 1 ∧ (re z < 0 ∨ im z ≠ 0)}` and continuous on the closed unit disk.

Also generalize `eq_on_of_eq_on_frontier` from a compact set to a bounded set (so that it works, e.g., for the unit ball in a Banach space).

This PR does not move the file `diff_on_int_cont` to make the diff more readable; the file will be moved in another PR.
@bors
Copy link

bors bot commented Apr 9, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Apr 9, 2022
…t_on_cl` (#13148)

Use "differentiable on a set and continuous on its closure" instead of "continuous on a set and differentiable on its interior".
There are a few reasons to prefer the latter:

* it has better "composition" lemma;
* it allows us to talk about functions that are, e.g., differentiable on `{z : ℂ | abs z < 1 ∧ (re z < 0 ∨ im z ≠ 0)}` and continuous on the closed unit disk.

Also generalize `eq_on_of_eq_on_frontier` from a compact set to a bounded set (so that it works, e.g., for the unit ball in a Banach space).

This PR does not move the file `diff_on_int_cont` to make the diff more readable; the file will be moved in another PR.
@bors
Copy link

bors bot commented Apr 9, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Apr 9, 2022
…t_on_cl` (#13148)

Use "differentiable on a set and continuous on its closure" instead of "continuous on a set and differentiable on its interior".
There are a few reasons to prefer the latter:

* it has better "composition" lemma;
* it allows us to talk about functions that are, e.g., differentiable on `{z : ℂ | abs z < 1 ∧ (re z < 0 ∨ im z ≠ 0)}` and continuous on the closed unit disk.

Also generalize `eq_on_of_eq_on_frontier` from a compact set to a bounded set (so that it works, e.g., for the unit ball in a Banach space).

This PR does not move the file `diff_on_int_cont` to make the diff more readable; the file will be moved in another PR.
@bors
Copy link

bors bot commented Apr 9, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title refactor(analysis/complex): replace diff_on_int_cont with diff_cont_on_cl [Merged by Bors] - refactor(analysis/complex): replace diff_on_int_cont with diff_cont_on_cl Apr 9, 2022
@bors bors bot closed this Apr 9, 2022
@bors bors bot deleted the YK-diff-cont-on-cl branch April 9, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants