-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - refactor(analysis/complex): replace diff_on_int_cont
with diff_cont_on_cl
#13148
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urkud
added
awaiting-review
The author would like community review of the PR
awaiting-CI
The author would like to see what CI has to say before doing more work.
labels
Apr 3, 2022
github-actions
bot
removed
the
awaiting-CI
The author would like to see what CI has to say before doing more work.
label
Apr 3, 2022
5 tasks
jcommelin
approved these changes
Apr 8, 2022
Thanks 🎉 bors merge |
github-actions
bot
added
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
and removed
awaiting-review
The author would like community review of the PR
labels
Apr 9, 2022
bors bot
pushed a commit
that referenced
this pull request
Apr 9, 2022
…t_on_cl` (#13148) Use "differentiable on a set and continuous on its closure" instead of "continuous on a set and differentiable on its interior". There are a few reasons to prefer the latter: * it has better "composition" lemma; * it allows us to talk about functions that are, e.g., differentiable on `{z : ℂ | abs z < 1 ∧ (re z < 0 ∨ im z ≠ 0)}` and continuous on the closed unit disk. Also generalize `eq_on_of_eq_on_frontier` from a compact set to a bounded set (so that it works, e.g., for the unit ball in a Banach space). This PR does not move the file `diff_on_int_cont` to make the diff more readable; the file will be moved in another PR.
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Apr 9, 2022
…t_on_cl` (#13148) Use "differentiable on a set and continuous on its closure" instead of "continuous on a set and differentiable on its interior". There are a few reasons to prefer the latter: * it has better "composition" lemma; * it allows us to talk about functions that are, e.g., differentiable on `{z : ℂ | abs z < 1 ∧ (re z < 0 ∨ im z ≠ 0)}` and continuous on the closed unit disk. Also generalize `eq_on_of_eq_on_frontier` from a compact set to a bounded set (so that it works, e.g., for the unit ball in a Banach space). This PR does not move the file `diff_on_int_cont` to make the diff more readable; the file will be moved in another PR.
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Apr 9, 2022
…t_on_cl` (#13148) Use "differentiable on a set and continuous on its closure" instead of "continuous on a set and differentiable on its interior". There are a few reasons to prefer the latter: * it has better "composition" lemma; * it allows us to talk about functions that are, e.g., differentiable on `{z : ℂ | abs z < 1 ∧ (re z < 0 ∨ im z ≠ 0)}` and continuous on the closed unit disk. Also generalize `eq_on_of_eq_on_frontier` from a compact set to a bounded set (so that it works, e.g., for the unit ball in a Banach space). This PR does not move the file `diff_on_int_cont` to make the diff more readable; the file will be moved in another PR.
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
refactor(analysis/complex): replace
[Merged by Bors] - refactor(analysis/complex): replace Apr 9, 2022
diff_on_int_cont
with diff_cont_on_cl
diff_on_int_cont
with diff_cont_on_cl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use "differentiable on a set and continuous on its closure" instead of "continuous on a set and differentiable on its interior".
There are a few reasons to prefer the latter:
{z : ℂ | abs z < 1 ∧ (re z < 0 ∨ im z ≠ 0)}
and continuous on the closed unit disk.Also generalize
eq_on_of_eq_on_frontier
from a compact set to a bounded set (so that it works, e.g., for the unit ball in a Banach space).This PR does not move the file
diff_on_int_cont
to make the diff more readable; the file will be moved in another PR.