Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(ring_theory/unique_factorization_domain): alternative specification for count (normalized_factors x) #13161

Closed
wants to merge 1 commit into from

Conversation

Vierkantor
Copy link
Collaborator

count_normalized_factors_eq specifies the number of times an irreducible factor p appears in normalized_factors x, namely the number of times it divides x. This is often easier to work with than going through multiplicity since this way we avoid coercing to enat.


Open in Gitpod

…ion for `count (normalized_factors x)`

`count_normalized_factors_eq` specifies the number of times an irreducible
factor `p` appears in `normalized_factors x`, namely the number of times it
divides `x`. This is often easier to work with than going through `multiplicity`
since this way we avoid coercing to `enat`
@Vierkantor Vierkantor added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Apr 4, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Apr 4, 2022
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Apr 8, 2022
bors bot pushed a commit that referenced this pull request Apr 8, 2022
…ion for `count (normalized_factors x)` (#13161)

`count_normalized_factors_eq` specifies the number of times an irreducible factor `p` appears in `normalized_factors x`, namely the number of times it divides `x`. This is often easier to work with than going through `multiplicity` since this way we avoid coercing to `enat`.
@bors
Copy link

bors bot commented Apr 8, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(ring_theory/unique_factorization_domain): alternative specification for count (normalized_factors x) [Merged by Bors] - feat(ring_theory/unique_factorization_domain): alternative specification for count (normalized_factors x) Apr 8, 2022
@bors bors bot closed this Apr 8, 2022
@bors bors bot deleted the count_normalized_factors_eq branch April 8, 2022 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants