Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(order/filter/pointwise): Missing pointwise operations #13170

Closed
wants to merge 13 commits into from
Closed

[Merged by Bors] - feat(order/filter/pointwise): Missing pointwise operations #13170

wants to merge 13 commits into from

Conversation

YaelDillies
Copy link
Collaborator

Define inversion/negation, division/subtraction, scalar multiplication/addition, scaling/translation, scalar subtraction of filters using the new filter.map₂. Golf the existing API.

Open in Gitpod

@YaelDillies YaelDillies added the awaiting-review The author would like community review of the PR label Apr 4, 2022
@semorrison semorrison added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Apr 5, 2022
@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Apr 6, 2022
jcommelin
jcommelin approved these changes Apr 9, 2022
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Apr 9, 2022
bors bot pushed a commit that referenced this pull request Apr 9, 2022
@YaelDillies
feat(order/filter/pointwise): Missing pointwise operations (#13170)
2d16005 
Define inversion/negation, division/subtraction, scalar multiplication/addition, scaling/translation, scalar subtraction of filters using the new `filter.map₂`. Golf the existing API.
@bors
Copy link

bors bot commented Apr 9, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Apr 9, 2022
@YaelDillies
feat(order/filter/pointwise): Missing pointwise operations (#13170)
08833ca 
Define inversion/negation, division/subtraction, scalar multiplication/addition, scaling/translation, scalar subtraction of filters using the new `filter.map₂`. Golf the existing API.
@bors
Copy link

bors bot commented Apr 9, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Apr 9, 2022
@YaelDillies
feat(order/filter/pointwise): Missing pointwise operations (#13170)
36466e7 
Define inversion/negation, division/subtraction, scalar multiplication/addition, scaling/translation, scalar subtraction of filters using the new `filter.map₂`. Golf the existing API.
@bors
Copy link

bors bot commented Apr 9, 2022

Build failed (retrying...):

@eric-wieser
Copy link
Member

bors r-

As requested

@bors
Copy link

bors bot commented Apr 9, 2022

Canceled.

@bryangingechen bryangingechen added awaiting-author A reviewer has asked the author a question or requested changes and removed ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) labels Apr 11, 2022
@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Apr 11, 2022
@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Apr 12, 2022
bors bot pushed a commit that referenced this pull request Apr 12, 2022
@YaelDillies
feat(order/filter/pointwise): Missing pointwise operations (#13170)
8b27c45 
Define inversion/negation, division/subtraction, scalar multiplication/addition, scaling/translation, scalar subtraction of filters using the new `filter.map₂`. Golf the existing API.
@bors
Copy link

bors bot commented Apr 12, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(order/filter/pointwise): Missing pointwise operations [Merged by Bors] - feat(order/filter/pointwise): Missing pointwise operations Apr 12, 2022
@bors bors bot closed this Apr 12, 2022
@bors bors bot deleted the more_filter_pointwise branch April 12, 2022 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@YaelDillies @eric-wieser @jcommelin @semorrison @bryangingechen @leanprover-community-bot-assistant