chore(analysis/normed/normed_field): rename normed_field to valued_field #13239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariainesdff
added
the
awaiting-review
|
There seems to be a consensus on zulip that this is not a desirable move (see for instance https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/normed_ring.20vs.20normed_field/near/278454583), so I am marking this as WIP for now. |
sgouezel
added
WIP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We rename the classes
normed_division_ringandnormed_fieldtovalued_division_ringandvalued_field, respectively.This is so that the old names can be used for classes in which the
norm_mulhypothesis is∀ a b, norm (a * b) ≤ norm a * norm b.The instance
[valued_ring.separated](https://leanprover-community.github.io/mathlib_docs/topology/algebra/valued_field.html#valued_ring.separated)gets renamed tovalued.separated, to avoid potential future name conflicts if avalued_ringclass is later introduced.