Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(category_theory/shift): restricting shift functors to a subcategory #13265

Closed
wants to merge 11 commits into from
Closed

[Merged by Bors] - feat(category_theory/shift): restricting shift functors to a subcategory #13265

wants to merge 11 commits into from

Conversation

semorrison
Copy link
Collaborator

@semorrison semorrison commented Apr 9, 2022 •
edited by github-actions bot
Loading

Given a family of endomorphisms of C which are interwined by a fully faithful F : C ⥤ D
with shift functors on D, we can promote that family to shift functors on C.

For LTE.

Open in Gitpod

@semorrison semorrison added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Apr 9, 2022
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Apr 9, 2022
jcommelin
jcommelin reviewed Apr 9, 2022
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/category_theory/shift.lean Outdated Show resolved Hide resolved
src/category_theory/shift.lean Outdated Show resolved Hide resolved
@semorrison semorrison mentioned this pull request Apr 9, 2022
Closed
3 tasks
@semorrison
Copy link
Collaborator Author

Okay, I've now tested this out in LTE, where it works beautifully to pull back the shift functor from bounded_homotopy_category to bounded_derived_category.

@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Apr 9, 2022
@leanprover-community-bot-assistant
Copy link
Collaborator

This PR/issue depends on:

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Apr 9, 2022
@jcommelin
Copy link
Member

bors d+

@bors
Copy link

bors bot commented Apr 9, 2022

✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Apr 9, 2022
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Apr 9, 2022
@semorrison
lint
d6dc307
@semorrison
Merge branches 'semorrison/shift_functors_subcategory' and 'semorriso…
7a73ade 
…n/shift_functors_subcategory' of github.com:leanprover-community/mathlib into semorrison/shift_functors_subcategory
@semorrison
Copy link
Collaborator Author

bors merge

@bors
Copy link

bors bot commented Apr 10, 2022

👎 Rejected by label

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Apr 10, 2022
@semorrison semorrison removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Apr 10, 2022
@semorrison
Copy link
Collaborator Author

bors merge

bors bot pushed a commit that referenced this pull request Apr 10, 2022
@semorrison @jcommelin
feat(category_theory/shift): restricting shift functors to a subcateg…
485ad0e 
…ory (#13265)

Given a family of endomorphisms of `C` which are interwined by a fully faithful `F : C ⥤ D`
with shift functors on `D`, we can promote that family to shift functors on `C`.

For LTE.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: Johan Commelin <johan@commelin.net>
@bors
Copy link

bors bot commented Apr 10, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Apr 10, 2022
@semorrison @jcommelin
feat(category_theory/shift): restricting shift functors to a subcateg…
ef51d23 
…ory (#13265)

Given a family of endomorphisms of `C` which are interwined by a fully faithful `F : C ⥤ D`
with shift functors on `D`, we can promote that family to shift functors on `C`.

For LTE.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: Johan Commelin <johan@commelin.net>
@bors
Copy link

bors bot commented Apr 10, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(category_theory/shift): restricting shift functors to a subcategory [Merged by Bors] - feat(category_theory/shift): restricting shift functors to a subcategory Apr 10, 2022
@bors bors bot closed this Apr 10, 2022
@bors bors bot deleted the semorrison/shift_functors_subcategory branch April 10, 2022 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin left review comments

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@semorrison @leanprover-community-bot-assistant @jcommelin