[Merged by Bors] - feat(ring_theory/tensor_product): add assoc for tensor product as an algebra homomorphism #13309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by speeding up a commented out def
alexjbest
added
awaiting-review
alexjbest
changed the title
github-actions
bot
removed
the
awaiting-CI
jcommelin
reviewed
Apr 11, 2022
|
Thanks! bors merge |
github-actions
bot
added
the
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Apr 13, 2022
…algebra homomorphism (#13309) By speeding up a commented out def, this goes from from ~100s to ~7s on my machine . Co-authored-by: Scott Morrison <scott@tqft.net>
github-actions
bot
removed
the
awaiting-review
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By speeding up a commented out def, this goes from from ~100s to ~7s on my machine .
Co-authored-by: Scott Morrison scott@tqft.net
Cc @semorrison who wrote this originally
It would be nice to understand the reason this is necessary, but I don't have good ideas for how to debug this
Vasily Ilin wants to make use of this, so any suggestions for additional helpful API are welcome :)