Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(deprecated/*): delete deprecated files #13353

Closed
wants to merge 13 commits into from

Conversation

semorrison
Copy link
Collaborator

@semorrison semorrison commented Apr 11, 2022

If we'd prefer to leave these in place for old times sake, that's fine with me; this PR marks the milestone that they are no longer imported by the rest of mathlib!


Open in Gitpod

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Apr 11, 2022
@semorrison semorrison added the awaiting-CI The author would like to see what CI has to say before doing more work. label Apr 11, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Apr 12, 2022
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Apr 12, 2022
@semorrison semorrison added RFC Request for comment awaiting-review The author would like community review of the PR labels Apr 12, 2022
@jcommelin
Copy link
Member

Thanks for decoupling mathlib from these files! I see that this PR is still doing some cleaning up, besides removing these files.

On the topic of removing deprecated/*: I think is_add_monoid_hom should not be a class. But it is a useful structure. And hence I would like to keep it around. So once mathlib is fully decoupled, I think we should do a refactors s/class/structure/, and then move these files out of deprecated/ and back into the main source tree.

@semorrison
Copy link
Collaborator Author

Hmm, this PR shouldn't be doing anything except deleting. Let me merge master again and see if it looks cleaner.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Apr 19, 2022
@semorrison
Copy link
Collaborator Author

Okay, I've added one more dependency, which cleans up some docs, and then this PR only deletes stuff. However, per the suggestion about is_add_monoid_hom, I will close this PR.

@semorrison
Copy link
Collaborator Author

I created a tracking issue at #13506. I have no intention of doing this. :-)

@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Apr 19, 2022
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Apr 21, 2022
@semorrison semorrison closed this Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review The author would like community review of the PR merge-conflict Please `git merge origin/master` then a bot will remove this label. RFC Request for comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants