Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(topology/bornology/basic): review #13374

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - feat(topology/bornology/basic): review #13374

wants to merge 1 commit into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Apr 12, 2022

  • add lemmas;
  • upgrade some implications to iffs.

Open in Gitpod

@urkud
feat(topology/bornology/basic): review
528247e 
* add lemmas;
* upgrade some implications to `iff`s.
@urkud urkud added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Apr 12, 2022
@urkud urkud requested a review from j-loreaux April 12, 2022 04:54
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Apr 12, 2022
jcommelin
jcommelin approved these changes Apr 12, 2022
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Apr 12, 2022
bors bot pushed a commit that referenced this pull request Apr 12, 2022
@urkud
feat(topology/bornology/basic): review (#13374)
36bafae 
* add lemmas;
* upgrade some implications to `iff`s.
@bors
Copy link

bors bot commented Apr 12, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(topology/bornology/basic): review [Merged by Bors] - feat(topology/bornology/basic): review Apr 12, 2022
@bors bors bot closed this Apr 12, 2022
@bors bors bot deleted the YK-born-lemmas branch April 12, 2022 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

@j-loreaux j-loreaux Awaiting requested review from j-loreaux

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@urkud @jcommelin @leanprover-community-bot-assistant