Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(analysis/normed_space/pointwise): Addition of balls #13381

Closed
wants to merge 9 commits into from
Closed

[Merged by Bors] - feat(analysis/normed_space/pointwise): Addition of balls #13381

wants to merge 9 commits into from

Conversation

YaelDillies
Copy link
Collaborator

@YaelDillies YaelDillies commented Apr 12, 2022 •
edited by github-actions bot

@YaelDillies YaelDillies added the awaiting-review The author would like community review of the PR label Apr 12, 2022
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Apr 12, 2022
@YaelDillies YaelDillies mentioned this pull request Apr 12, 2022
Closed
1 task
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Apr 15, 2022
sgouezel
sgouezel reviewed Apr 26, 2022
View reviewed changes
src/analysis/normed/group/pointwise.lean Outdated Show resolved Hide resolved
src/analysis/normed/group/pointwise.lean Outdated Show resolved Hide resolved
src/analysis/normed/group/pointwise.lean Outdated Show resolved Hide resolved
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Apr 26, 2022
@leanprover-community-bot-assistant
Copy link
Collaborator

This PR/issue depends on:

@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Apr 26, 2022
sgouezel
sgouezel reviewed Apr 26, 2022
View reviewed changes
Copy link
Collaborator

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please fix the build?

src/analysis/normed/group/pointwise.lean Outdated Show resolved Hide resolved
src/analysis/normed/group/pointwise.lean Outdated Show resolved Hide resolved
@sgouezel sgouezel added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Apr 26, 2022
@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. and removed awaiting-author A reviewer has asked the author a question or requested changes labels Apr 27, 2022
@YaelDillies YaelDillies mentioned this pull request Apr 27, 2022
Closed
5 tasks
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Apr 28, 2022
jcommelin
jcommelin approved these changes Apr 29, 2022
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Apr 29, 2022
bors bot pushed a commit that referenced this pull request Apr 29, 2022
@YaelDillies
feat(analysis/normed_space/pointwise): Addition of balls (#13381)
812e17f 
Adding two balls yields another ball.
@bors
Copy link

bors bot commented Apr 29, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(analysis/normed_space/pointwise): Addition of balls [Merged by Bors] - feat(analysis/normed_space/pointwise): Addition of balls Apr 29, 2022
@bors bors bot closed this Apr 29, 2022
@bors bors bot deleted the ball_add_ball branch April 29, 2022 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgouezel sgouezel sgouezel left review comments

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@YaelDillies @leanprover-community-bot-assistant @jcommelin @sgouezel