[Merged by Bors] - chore(*): remove instance arguments that are inferrable from earlier #13386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjbest
added
awaiting-review
YaelDillies
reviewed
Apr 12, 2022
github-actions
bot
removed
the
awaiting-CI
bors bot
pushed a commit
that referenced
this pull request
Apr 12, 2022
…13386) Some lemmas have typeclass arguments that are in fact inferrable from the earlier ones, at least when everything is Prop valued this is unecessary so we clean up a few cases as they likely stem from typos or library changes. - `src/field_theory/finiteness.lean` it wasn't known at the time (#7644) that a division ring was noetherian, but now it is (#7661) - `src/category_theory/simple.lean` any abelian category has all cokernels so no need to assume it seperately - `src/analysis/convex/extreme.lean` assumed `linear_ordered_field` and `no_smul_zero_divisors` which is unnecessary, we take this as a sign that this and a couple of other convexity results should be generalized to densely ordered linear ordered rings (of which there are examples that are not fields) cc @YaelDillies
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
YaelDillies
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some lemmas have typeclass arguments that are in fact inferrable from the earlier ones, at least when everything is Prop valued this is unecessary so we clean up a few cases as they likely stem from typos or library changes.
src/field_theory/finiteness.leanit wasn't known at the time ([Merged by Bors] - refactor(linear_algebra/finite_dimensional): generalize finite_dimensional.iff_fg to division rings #7644) that a division ring was noetherian, but now it is ([Merged by Bors] - feat(ring_theory): every division_ring is_noetherian #7661)src/category_theory/simple.leanany abelian category has all cokernels so no need to assume it seperatelysrc/analysis/convex/extreme.leanassumedlinear_ordered_fieldandno_smul_zero_divisorswhich is unnecessary, we take this as a sign that this and a couple of other convexity results should be generalized to densely ordered linear ordered rings (of which there are examples that are not fields) cc @YaelDillies