[Merged by Bors] - feat(algebra/*/basic): add trivial lemmas #13416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericrbg
added
awaiting-CI
8 tasks
riccardobrasca
approved these changes
Apr 13, 2022
github-actions
bot
removed
the
awaiting-CI
eric-wieser
reviewed
Apr 13, 2022
| @@ -855,6 +860,11 @@ protected def function.surjective.non_assoc_ring | |||
| { .. hf.add_comm_group f zero add neg sub nsmul gsmul, .. hf.mul_zero_class f zero mul, | |||
| .. hf.distrib f add mul, .. hf.mul_one_class f one mul } | |||
|
|
|||
| lemma sub_one_mul (a b : α) : (a - 1) * b = a * b - b := | |||
There was a problem hiding this comment.
Probably worth having one_sub_mul too
There was a problem hiding this comment.
should I go full ham and go for one_add_mul as well? or is that too much
|
Thanks! bors d+ |
|
✌️ ericrbg can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 19, 2022
These save you from having to fiddle with `mul_one` when you want to rewrite them the other way, or allow easier commutativity rewrites. Co-authored-by: Eric Rodriguez <37984851+ericrbg@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These save you from having to fiddle with
mul_onewhen you want to rewrite them the other way, or allow easier commutativity rewrites.