Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(*): clean up unnecessary uses of nat.cases_on #13454

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - chore(*): clean up unnecessary uses of nat.cases_on #13454

wants to merge 2 commits into from

Conversation

alexjbest
Copy link
Member

Open in Gitpod

@eric-wieser eric-wieser added the awaiting-CI The author would like to see what CI has to say before doing more work. label Apr 15, 2022
eric-wieser
eric-wieser approved these changes Apr 15, 2022
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

CI isn't quite happy, but I'm sure you can get it to be!

I assume this was found with a metaprogram?

@bors
Copy link

bors bot commented Apr 15, 2022

✌️ alexjbest can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the delegated The PR author may merge after reviewing final suggestions. label Apr 15, 2022
@alexjbest
Copy link
Member Author

They were found by a metaprogram indeed, sort of the same idea as when I looked by_cases calls before, one can inspect the generated term and see if the proof in the nat.succ case actually just generalizes and works in all cases.
I'm working on extending this to all inductive types now, this was just a nice first example.

@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Apr 15, 2022
@alexjbest
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Apr 15, 2022
@alexjbest
chore(*): clean up unnecessary uses of nat.cases_on (#13454)
bbbea1c
@bors
Copy link

bors bot commented Apr 15, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(*): clean up unnecessary uses of nat.cases_on [Merged by Bors] - chore(*): clean up unnecessary uses of nat.cases_on Apr 15, 2022
@bors bors bot closed this Apr 15, 2022
@bors bors bot deleted the alexjbest/cleanup_nat_cases branch April 15, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexjbest @eric-wieser @leanprover-community-bot-assistant