Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(data/fin): val simp lemmas #1347

Merged
merged 2 commits into from
Aug 19, 2019
Merged

feat(data/fin): val simp lemmas #1347

merged 2 commits into from
Aug 19, 2019

Conversation

ChrisHughes24
Copy link
Member

TO CONTRIBUTORS:

Make sure you have:

  • reviewed and applied the coding style: coding, naming
  • reviewed and applied the documentation requirements
  • for tactics:
  • make sure definitions and lemmas are put in the right files
  • make sure definitions and lemmas are not redundant

If this PR is related to a discussion on Zulip, please include a link in the discussion.

For reviewers: code review check list

@ChrisHughes24 ChrisHughes24 requested a review from a team as a code owner August 19, 2019 15:07
@cipher1024 cipher1024 added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Aug 19, 2019
@mergify mergify bot merged commit 92fa24c into master Aug 19, 2019
@mergify mergify bot deleted the ChrisHughes24-patch-2 branch August 19, 2019 17:10
cipher1024 pushed a commit that referenced this pull request Aug 23, 2019
* feat(data/fin): val simp lemmas

* Update fin.lean
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 15, 2020
* feat(data/fin): val simp lemmas

* Update fin.lean
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants