Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(topology/stone_cech): add stone_cech_hom_ext #13472

Closed
wants to merge 3 commits into from

Conversation

mapehe
Copy link
Collaborator

@mapehe mapehe commented Apr 15, 2022

The universal property that characterises the Stone–Čech compactification of a topological space X is that any function from X to a compact Hausdorff space extends uniquely to a continuous function on βX. Existence is already provided by unique_stone_cech_extend, but it seems that the uniqueness lemma was intentionally omitted previously. Easy, but probably worth being explicit about.


Open in Gitpod

@mapehe mapehe added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR labels Apr 15, 2022
Comment on lines 266 to 267
(hfg: g ∘ stone_cech_unit = (stone_cech_extend hf) ∘ stone_cech_unit):
g = stone_cech_extend hf :=
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(hfg: g ∘ stone_cech_unit = (stone_cech_extend hf) ∘ stone_cech_unit):
g = stone_cech_extend hf :=
(hfg: g ∘ stone_cech_unit = (stone_cech_extend hf) ∘ stone_cech_unit) :
g = stone_cech_extend hf :=

Just some minor spacing issues

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an autoformatter for lean btw?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an autoformatter for lean btw?

I don't know! That would be useful indeed!

@adamtopaz
Copy link
Collaborator

adamtopaz commented Apr 15, 2022

The following lemma may be slightly more useful:

lemma stone_cech_hom_ext {g₁ g₂ : stone_cech α → γ} 
  (h₁ : continuous g₁) (h₂ : continuous g₂) 
  (h : g₁ ∘ stone_cech_unit = g₂ ∘ stone_cech_unit) : g₁ = g₂ :=
begin
  apply continuous.ext_on dense_range_stone_cech_unit h₁ h₂,
  rintros x ⟨x, rfl⟩,
  apply (congr_fun h x)
end

@mapehe
Copy link
Collaborator Author

mapehe commented Apr 15, 2022

Thanks @adamtopaz, agreed that your formulation is more useful and commited your suggestion. 🙏

Copy link
Collaborator

@adamtopaz adamtopaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'll wait to see if there are any other comments, and for CI to finish before merging.
(It would be good to get another reviewer's comments, since I suggested the current formulation of the lemma.)

@mapehe mapehe changed the title unique_stone_cech_extend stone_cech_hom_ext Apr 16, 2022
@mapehe mapehe changed the title stone_cech_hom_ext feat(topology/stone_cech): add stone_cech_hom_ext Apr 16, 2022
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Apr 16, 2022
bors bot pushed a commit that referenced this pull request Apr 16, 2022
The universal property that characterises the Stone–Čech compactification of a topological space X is that any function from X to a compact Hausdorff space extends uniquely to a continuous function on βX. Existence is already provided by `unique_stone_cech_extend`, but it seems that the uniqueness lemma was intentionally omitted previously. Easy, but probably worth being explicit about.



Co-authored-by: Matias Heikkilä <matias@three.consulting>
@bors
Copy link

bors bot commented Apr 16, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(topology/stone_cech): add stone_cech_hom_ext [Merged by Bors] - feat(topology/stone_cech): add stone_cech_hom_ext Apr 16, 2022
@bors bors bot closed this Apr 16, 2022
@bors bors bot deleted the unique_stone_cech_extend branch April 16, 2022 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants