Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(number_theory/legendre_symbol/quadratic_reciprocity): replace [fact (p % 2 = 1)] arguments by (p ≠ 2) #13474

Closed
wants to merge 3 commits into from

Conversation

MichaelStollBayreuth
Copy link
Collaborator

This removes implicit arguments of the form [fact (p % 2 = 1)] and replaces them by explicit arguments (hp : p ≠ 2).

(See the short discussion on April 9 in this topic.)


Open in Gitpod

@MichaelStollBayreuth MichaelStollBayreuth added the awaiting-review The author would like community review of the PR label Apr 15, 2022
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Apr 16, 2022
@MichaelStollBayreuth MichaelStollBayreuth added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Apr 16, 2022
@ocfnash ocfnash added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Apr 17, 2022
@MichaelStollBayreuth MichaelStollBayreuth added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Apr 18, 2022
@ocfnash
Copy link
Collaborator

ocfnash commented Apr 18, 2022

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Apr 18, 2022
bors bot pushed a commit that referenced this pull request Apr 18, 2022
…fact (p % 2 = 1)]` arguments by `(p ≠ 2)` (#13474)

This removes implicit arguments of the form `[fact (p % 2 = 1)]` and replaces them by explicit arguments `(hp : p ≠ 2)`.

(See the short discussion on April 9 in [this topic](https://leanprover.zulipchat.com/#narrow/stream/116395-maths/topic/Quadratic.20Hilbert.20symbol.20over.20.E2.84.9A).)
@bors
Copy link

bors bot commented Apr 18, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(number_theory/legendre_symbol/quadratic_reciprocity): replace [fact (p % 2 = 1)] arguments by (p ≠ 2) [Merged by Bors] - feat(number_theory/legendre_symbol/quadratic_reciprocity): replace [fact (p % 2 = 1)] arguments by (p ≠ 2) Apr 18, 2022
@bors bors bot closed this Apr 18, 2022
@bors bors bot deleted the legendre_symbol branch April 18, 2022 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants