Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - refactor(category_theory): make has_zero_object a Prop #13517

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - refactor(category_theory): make has_zero_object a Prop #13517

wants to merge 6 commits into from

Conversation

jcommelin
Copy link
Member

@jcommelin jcommelin commented Apr 19, 2022 •
edited by github-actions bot

@jcommelin jcommelin added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Apr 19, 2022
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Apr 19, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Apr 19, 2022
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Apr 19, 2022
@leanprover-community-bot-assistant
Copy link
Collaborator

This PR/issue depends on:

adamtopaz
adamtopaz reviewed Apr 21, 2022
View reviewed changes
Copy link
Collaborator

@adamtopaz adamtopaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one minor comment for you to consider.

bors d+

src/algebra/homology/single.lean
@@ -164,8 +166,9 @@ is the same as the zero functor.
-/
noncomputable
def homology_functor_succ_single₀ (n : ℕ) : single₀ V ⋙ homology_functor V _ (n+1) ≅ 0 :=
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add a is_zero instance based on this isomorphisms (and its variant(s) below)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will do this in a follow-up PR

@bors
Copy link

bors bot commented Apr 21, 2022

✌️ jcommelin can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Apr 21, 2022
@jcommelin
Copy link
Member Author

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Apr 21, 2022
bors bot pushed a commit that referenced this pull request Apr 21, 2022
@jcommelin
refactor(category_theory): make has_zero_object a Prop (#13517)
ceddeda
@bors
Copy link

bors bot commented Apr 21, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Apr 21, 2022
@jcommelin
refactor(category_theory): make has_zero_object a Prop (#13517)
388c3c2
@bors
Copy link

bors bot commented Apr 21, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Apr 22, 2022
@jcommelin
refactor(category_theory): make has_zero_object a Prop (#13517)
77236cd
@bors
Copy link

bors bot commented Apr 22, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title refactor(category_theory): make has_zero_object a Prop [Merged by Bors] - refactor(category_theory): make has_zero_object a Prop Apr 22, 2022
@bors bors bot closed this Apr 22, 2022
@bors bors bot deleted the zero-object-prop branch April 22, 2022 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamtopaz adamtopaz adamtopaz left review comments

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jcommelin @leanprover-community-bot-assistant @adamtopaz