Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - refactor(category_theory): reverse simp lemmas about (co)forks #13519

Closed
wants to merge 17 commits into from

Conversation

javra
Copy link
Collaborator

@javra javra commented Apr 19, 2022

Makes fork.ι instead of t.π.app zero so that we avoid any unnecessary references to walking_parallel_pair in (co)fork homs. This induces quite a lot of changes in other files, but I think it's worth the pain. The PR also changes fork.is_limit.mk to avoid stating redundant morphisms.


Open in Gitpod

@javra javra added the awaiting-review The author would like community review of the PR label Apr 19, 2022
@javra javra requested review from TwoFX and adamtopaz April 19, 2022 15:00
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Apr 21, 2022
bors bot pushed a commit that referenced this pull request Apr 21, 2022
Makes `fork.ι` instead of `t.π.app zero` so that we avoid any unnecessary references to `walking_parallel_pair` in (co)fork  homs. This induces quite a lot of changes in other files, but I think it's worth the pain. The PR also changes `fork.is_limit.mk` to avoid stating redundant morphisms.
@bors
Copy link

bors bot commented Apr 21, 2022

Build failed (retrying...):

@javra
Copy link
Collaborator Author

javra commented Apr 21, 2022

The point where it fails doesn't seem to be related to the PR...

@javra
Copy link
Collaborator Author

javra commented Apr 21, 2022

Any clue, @TwoFX ?

bors bot pushed a commit that referenced this pull request Apr 21, 2022
Makes `fork.ι` instead of `t.π.app zero` so that we avoid any unnecessary references to `walking_parallel_pair` in (co)fork  homs. This induces quite a lot of changes in other files, but I think it's worth the pain. The PR also changes `fork.is_limit.mk` to avoid stating redundant morphisms.
@bors
Copy link

bors bot commented Apr 21, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title refactor(category_theory): reverse simp lemmas about (co)forks [Merged by Bors] - refactor(category_theory): reverse simp lemmas about (co)forks Apr 21, 2022
@bors bors bot closed this Apr 21, 2022
@bors bors bot deleted the fork-simp-lemmas branch April 21, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants