Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(data/real/ennreal): tsub lemmas #13525

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - feat(data/real/ennreal): tsub lemmas #13525

wants to merge 4 commits into from

Conversation

YaelDillies
Copy link
Collaborator

@YaelDillies YaelDillies commented Apr 19, 2022 •
edited

Inherit lemmas about subtraction on ℝ≥0∞ from algebra.order.sub. Generalize add_le_cancellable.tsub_lt_self in passing.

New ennreal lemmas

  • sub_eq_of_eq_add
  • eq_sub_of_add_eq
  • sub_eq_of_eq_add_rev
  • lt_add_of_sub_lt_right
  • sub_lt_self_iff

Renames

  • add_sub_self → add_sub_cancel_right
  • add_sub_self' → add_sub_cancel_left
  • lt_add_of_sub_lt → lt_add_of_sub_lt_left

Open in Gitpod

@YaelDillies YaelDillies added the awaiting-review The author would like community review of the PR label Apr 19, 2022
@YaelDillies YaelDillies mentioned this pull request Apr 19, 2022
Closed
4 tasks
@eric-wieser
Copy link
Member

Can you list the new lemmas in the PR description? It's hard to tell what's new and whats reordered.

@eric-wieser eric-wieser added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Apr 20, 2022
@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Apr 20, 2022
jcommelin
jcommelin approved these changes Apr 21, 2022
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Apr 21, 2022
bors bot pushed a commit that referenced this pull request Apr 21, 2022
@YaelDillies
feat(data/real/ennreal): tsub lemmas (#13525)
a2137ef 
Inherit lemmas about subtraction on `ℝ≥0∞` from `algebra.order.sub`. Generalize `add_le_cancellable.tsub_lt_self` in passing.

New `ennreal` lemmas
@bors
Copy link

bors bot commented Apr 21, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Apr 21, 2022
@YaelDillies
feat(data/real/ennreal): tsub lemmas (#13525)
08323cd 
Inherit lemmas about subtraction on `ℝ≥0∞` from `algebra.order.sub`. Generalize `add_le_cancellable.tsub_lt_self` in passing.

New `ennreal` lemmas
@bors
Copy link

bors bot commented Apr 21, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/real/ennreal): tsub lemmas [Merged by Bors] - feat(data/real/ennreal): tsub lemmas Apr 21, 2022
@bors bors bot closed this Apr 21, 2022
@bors bors bot deleted the ennreal_tsub branch April 21, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@YaelDillies @eric-wieser @jcommelin @leanprover-community-bot-assistant