[Merged by Bors] - chore(set_theory/game/*): Protect ambiguous lemmas #13557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaelDillies
added
the
awaiting-review
leanprover-community-bot-assistant
added
blocked-by-other-PR
|
This PR/issue depends on:
|
leanprover-community-bot-assistant
added
the
merge-conflict
leanprover-community-bot-assistant
removed
the
merge-conflict
|
I merged with master, since #13530 was just merged. |
vihdzp
reviewed
Apr 21, 2022
leanprover-community-bot-assistant
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Apr 21, 2022
Protect `pgame.neg_zero` and inline `pgame.add_le_add_left` and friends into `covariant_class` instances. Co-authored-by: Violeta Hernández <vi.hdz.p@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
YaelDillies
changed the title
ericrbg
reviewed
Apr 21, 2022
| @@ -152,7 +152,7 @@ lemma le_zero_iff {G : pgame} [G.impartial] : G ≤ 0 ↔ 0 ≤ G := | |||
| by rw [le_zero_iff_zero_le_neg, le_congr (equiv_refl 0) (neg_equiv_self G)] | |||
|
|
|||
| lemma lt_zero_iff {G : pgame} [G.impartial] : G < 0 ↔ 0 < G := | |||
| by rw [lt_iff_neg_gt, neg_zero, lt_congr (equiv_refl 0) (neg_equiv_self G)] | |||
| by rw [lt_iff_neg_gt, pgame.neg_zero, lt_congr (equiv_refl 0) (neg_equiv_self G)] | |||
There was a problem hiding this comment.
why does pgame have its own neg_zero? do neither neg_zero nor neg_zero' work for it?
There was a problem hiding this comment.
No, pgame is pretty badly behaved. Most results about pgame are not equalities but double inequalities (a ≤ b ∧ b ≤ a instead of a = b). pgame.neg_zero is actually the exception here. Once you take the antisymmetrization, you get game, which is much saner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protect
pgame.neg_zeroand inlinepgame.add_le_add_leftand friends intocovariant_classinstances.