Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(analysis/calculus/deriv): generalize some lemmas #13575

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - feat(analysis/calculus/deriv): generalize some lemmas #13575

wants to merge 4 commits into from

Conversation

negiizhao
Copy link
Collaborator

@negiizhao negiizhao commented Apr 21, 2022 •
edited

The types of scalar and codomain can be different now.

For example, these lemmas can be used for f : ℝ → ℂ f' : ℝ →L[ℝ] ℂ now.

Open in Gitpod

@negiizhao negiizhao added the awaiting-review The author would like community review of the PR label Apr 21, 2022
@negiizhao negiizhao mentioned this pull request Apr 21, 2022
Closed
1 task
@eric-wieser
Copy link
Member

Can you explain in the PR description what's going on here? The diff alone just looks like it renames variables; but I assume the new variables have more general types?

@negiizhao
Copy link
Collaborator Author

Ok, there is a description now.

sgouezel
sgouezel reviewed May 6, 2022
View reviewed changes
Copy link
Collaborator

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

src/analysis/calculus/deriv.lean Outdated Show resolved Hide resolved
src/analysis/calculus/deriv.lean Outdated Show resolved Hide resolved
@sgouezel sgouezel added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels May 6, 2022
@negiizhao negiizhao added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. and removed awaiting-author A reviewer has asked the author a question or requested changes labels May 6, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label May 7, 2022
@semorrison
Copy link
Collaborator

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels May 7, 2022
bors bot pushed a commit that referenced this pull request May 7, 2022
@negiizhao
feat(analysis/calculus/deriv): generalize some lemmas (#13575)
b2aa27e 
The types of scalar and codomain can be different now.

For example, these lemmas can be used for `f : ℝ → ℂ` `f' : ℝ →L[ℝ] ℂ` now.
@bors
Copy link

bors bot commented May 7, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(analysis/calculus/deriv): generalize some lemmas [Merged by Bors] - feat(analysis/calculus/deriv): generalize some lemmas May 7, 2022
@bors bors bot closed this May 7, 2022
@bors bors bot deleted the FR_deriv_lemma branch May 7, 2022 11:58
bors bot pushed a commit that referenced this pull request May 14, 2022
@negiizhao
feat(analysis/special_functions/exp_deriv): generalize some lemmas ab…
e738612 
…out `complex.exp`, remove `*.cexp_real` (#13579)

Now we can use `*.cexp` instead of some previous `*.cexp_real` lemmas.

- [x] depends on: #13575
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgouezel sgouezel sgouezel left review comments

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@negiizhao @eric-wieser @semorrison @sgouezel