[Merged by Bors] - refactor(number_theory/padics/padic_norm): split file #13576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BoltonBailey
added
the
awaiting-CI
4 tasks
BoltonBailey
added
easy
github-actions
bot
removed
the
awaiting-CI
BoltonBailey
added
the
awaiting-review
3 tasks
leanprover-community-bot-assistant
added
ready-to-merge
|
Merge conflict. |
leanprover-community-bot-assistant
added
the
merge-conflict
leanprover-community-bot-assistant
removed
the
merge-conflict
BoltonBailey
added
the
awaiting-review
|
There was a merge conflict that I fixed, not sure if this needs to be told to merge again |
BoltonBailey
removed
ready-to-merge
|
Seems 13562 made some changes, let me fix this |
…-community/mathlib into BoltonBailey/split-padic-norm
BoltonBailey
added
the
awaiting-review
|
Thanks! bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Apr 26, 2022
This PR splits the initial part of the `padic_norm.lean` file that defines p-adic valuations into a new file called `padic_val.lean`. This split makes sense to me since it seems most files importing this don't actually use the norm, so those files can build more in parallel. It also seems like a good organizational change: This way people can look at the files in this directory and see immediately where the valuation is defined, and people looking for the definition of `padic_norm` in `padic_norm.lean` don't have to scroll.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits the initial part of the
padic_norm.leanfile that defines p-adic valuations into a new file calledpadic_val.lean. This split makes sense to me since it seems most files importing this don't actually use the norm, so those files can build more in parallel. It also seems like a good organizational change: This way people can look at the files in this directory and see immediately where the valuation is defined, and people looking for the definition ofpadic_norminpadic_norm.leandon't have to scroll.