Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(data/list/*): Miscellaneous lemmas #13577

Closed
wants to merge 3 commits into from

Conversation

YaelDillies
Copy link
Collaborator

A few lemmas about list.chain, list.pairwise. Also rename list.chain_of_pairwise to list.pairwise.chain for dot notation.


Open in Gitpod

@YaelDillies YaelDillies added the awaiting-review The author would like community review of the PR label Apr 21, 2022
src/data/list/pairwise.lean Outdated Show resolved Hide resolved
src/logic/relation.lean Show resolved Hide resolved
src/data/list/basic.lean Outdated Show resolved Hide resolved
end, chain_of_pairwise⟩
⟨chain.pairwise tr, pairwise.chain⟩

protected lemma chain.sublist [is_trans α R] (hl : l₂.chain R a) (h : l₁ <+ l₂) : l₁.chain R a :=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any convention about (h : transitive R) vs [is_trans α R]?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that I know of, unfortunately...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding was the is_trans was introduced as part of the "The big algebra typeclass refactor" that never happened.

@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Apr 26, 2022
bors bot pushed a commit that referenced this pull request Apr 26, 2022
A few lemmas about `list.chain`, `list.pairwise`. Also rename `list.chain_of_pairwise` to `list.pairwise.chain` for dot notation.
@bors
Copy link

bors bot commented Apr 26, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/list/*): Miscellaneous lemmas [Merged by Bors] - feat(data/list/*): Miscellaneous lemmas Apr 26, 2022
@bors bors bot closed this Apr 26, 2022
@bors bors bot deleted the forall_of_forall_of_flip branch April 26, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants