Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(number_theory/legendre_symbol/quadratic_reciprocity): Alternate forms of exists_sq_eq_neg_one #13594

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - feat(number_theory/legendre_symbol/quadratic_reciprocity): Alternate forms of exists_sq_eq_neg_one #13594

wants to merge 3 commits into from

Conversation

vihdzp
Copy link
Collaborator

@vihdzp vihdzp commented Apr 22, 2022 •
edited

Also, renamed exists_sq_eq_neg_one_iff_mod_four_ne_three to exists_sq_eq_neg_one for consistency with exists_sq_eq_two and for convenience.

Open in Gitpod

@vihdzp vihdzp added the awaiting-review The author would like community review of the PR label Apr 22, 2022
@vihdzp vihdzp changed the title feat(number_theory/legendre_symbol/quadratic_reciprocity): Alternate forms of exists_sq_eq_neg_one_iff_mod_four_ne_three feat(number_theory/legendre_symbol/quadratic_reciprocity): Alternate forms of exists_sq_eq_neg_one_iff_mod_four_ne_three Apr 22, 2022
@vihdzp vihdzp changed the title feat(number_theory/legendre_symbol/quadratic_reciprocity): Alternate forms of exists_sq_eq_neg_one_iff_mod_four_ne_three feat(number_theory/legendre_symbol/quadratic_reciprocity): Alternate forms of exists_sq_eq_neg_one Apr 22, 2022
jcommelin
jcommelin approved these changes Apr 25, 2022
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Apr 25, 2022
bors bot pushed a commit that referenced this pull request Apr 25, 2022
@vihdzp
feat(number_theory/legendre_symbol/quadratic_reciprocity): Alternate …
d795ea4 
…forms of `exists_sq_eq_neg_one` (#13594)

Also, renamed `exists_sq_eq_neg_one_iff_mod_four_ne_three` to `exists_sq_eq_neg_one` for consistency with `exists_sq_eq_two` and for convenience.
@bors
Copy link

bors bot commented Apr 25, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(number_theory/legendre_symbol/quadratic_reciprocity): Alternate forms of exists_sq_eq_neg_one [Merged by Bors] - feat(number_theory/legendre_symbol/quadratic_reciprocity): Alternate forms of exists_sq_eq_neg_one Apr 25, 2022
@bors bors bot closed this Apr 25, 2022
@bors bors bot deleted the mod_four_ne_three_of_sq_eq_neg_one branch April 25, 2022 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vihdzp @jcommelin @leanprover-community-bot-assistant