Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(set_theory/game/pgame): Tweak pgame.neg API #13617

Closed
wants to merge 15 commits into from
Closed

[Merged by Bors] - feat(set_theory/game/pgame): Tweak pgame.neg API #13617

wants to merge 15 commits into from

Conversation

vihdzp
Copy link
Collaborator

@vihdzp vihdzp commented Apr 22, 2022 •
edited

We modify the API for pgame.neg in various ways:

  • left_moves_neg and right_moves_neg are turned from type equivalences into type equalities.
  • The former equivalences are prefixed with to_ and inverted.

We also golf a few theorems.

Open in Gitpod

@vihdzp vihdzp added the awaiting-review The author would like community review of the PR label Apr 22, 2022
@vihdzp vihdzp changed the title feat(set_theory/game/pgame): Improve pgame.neg API feat(set_theory/game/pgame): Tweak pgame.neg API Apr 22, 2022
@semorrison semorrison added the awaiting-author A reviewer has asked the author a question or requested changes label Apr 24, 2022
@semorrison semorrison added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label May 2, 2022
@vihdzp vihdzp removed the awaiting-author A reviewer has asked the author a question or requested changes label May 2, 2022
@semorrison semorrison removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label May 2, 2022
jcommelin
jcommelin approved these changes May 4, 2022
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels May 4, 2022
bors bot pushed a commit that referenced this pull request May 4, 2022
@vihdzp
feat(set_theory/game/pgame): Tweak pgame.neg API (#13617)
2402b4d 
We modify the API for `pgame.neg` in various ways: 

- `left_moves_neg` and `right_moves_neg` are turned from type equivalences into type equalities.
- The former equivalences are prefixed with `to_` and inverted.

We also golf a few theorems.
@bors
Copy link

bors bot commented May 4, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(set_theory/game/pgame): Tweak pgame.neg API [Merged by Bors] - feat(set_theory/game/pgame): Tweak pgame.neg API May 4, 2022
@bors bors bot closed this May 4, 2022
@bors bors bot deleted the neg_pgame_api branch May 4, 2022 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semorrison semorrison semorrison left review comments

@YaelDillies YaelDillies YaelDillies left review comments

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vihdzp @semorrison @jcommelin @YaelDillies @leanprover-community-bot-assistant