[Merged by Bors] - chore(analysis/convex): move convex_on_norm, change API
#13631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urkud
added
awaiting-review
urkud
commented
Apr 22, 2022
urkud
commented
Apr 22, 2022
github-actions
bot
removed
the
awaiting-CI
2 tasks
YaelDillies
reviewed
Apr 25, 2022
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
I don't know either. I just fixed the inconsistency in API.
IMHO, we should add it whenever we need it. |
|
Thanks! bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Apr 29, 2022
* Move `convex_on_norm` from `specific_functions` to `topology`, use it to golf the proof of `convex_on_dist`. * The old `convex_on_norm` is now called `convex_on_univ_norm`. The new `convex_on_norm` is about convexity on any convex set. * Add `convex_on_univ_dist` and make `s : set E` an implicit argument in `convex_on_dist`. This way APIs about convexity of norm and distance agree.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
convex_on_norm, change APIconvex_on_norm, change API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
convex_on_normfromspecific_functionstotopology, use it to golf the proof ofconvex_on_dist.convex_on_normis now calledconvex_on_univ_norm. The newconvex_on_normis about convexity on any convex set.convex_on_univ_distand makes : set Ean implicit argument inconvex_on_dist.This way APIs about convexity of norm and distance agree.