Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(field_theory/finite/polynomial): tidy + remove nolints #13645

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - chore(field_theory/finite/polynomial): tidy + remove nolints #13645

wants to merge 1 commit into from

Conversation

ericrbg
Copy link
Collaborator

@ericrbg ericrbg commented Apr 23, 2022 •
edited

Some of these definitions only make full sense over a field (for example the indicator function can be nonsensical in non-field rings) but there's also no reason not to define them more generally. This removes all nolints related to this file, and all of the generalisation linter suggestions too.

Open in Gitpod

@ericrbg ericrbg added awaiting-CI The author would like to see what CI has to say before doing more work. awaiting-review The author would like community review of the PR lintfix This PR only fixes linting errors labels Apr 23, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Apr 23, 2022
jcommelin
jcommelin approved these changes Apr 25, 2022
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Apr 25, 2022
bors bot pushed a commit that referenced this pull request Apr 25, 2022
@ericrbg
chore(field_theory/finite/polynomial): tidy + remove nolints (#13645)
962bfcd 
Some of these definitions only make full sense over a field (for example the indicator function can be nonsensical in non-field rings) but there's also no reason not to define them more generally. This removes all `nolint`s related to this file, and all of the generalisation linter suggestions too.
@bors
Copy link

bors bot commented Apr 25, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(field_theory/finite/polynomial): tidy + remove nolints [Merged by Bors] - chore(field_theory/finite/polynomial): tidy + remove nolints Apr 25, 2022
@bors bors bot closed this Apr 25, 2022
@bors bors bot deleted the ericrbg/tidy_finite_poly branch April 25, 2022 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
lintfix This PR only fixes linting errors ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ericrbg @jcommelin @leanprover-community-bot-assistant