Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(set_theory/game/pgame): x.move_left i < x and variants #13654

Closed
wants to merge 3 commits into from

Conversation

vihdzp
Copy link
Collaborator

@vihdzp vihdzp commented Apr 24, 2022


Open in Gitpod

@vihdzp vihdzp added the awaiting-review The author would like community review of the PR label Apr 24, 2022
@vihdzp vihdzp changed the title feat(set_theory/game/pgame): x^L < x and variants feat(set_theory/game/pgame): x.move_left i < x and variants Apr 24, 2022
@semorrison
Copy link
Collaborator

Thanks! This is a better way to handle it.

If you feel like adding a few sentences of comments, it might be worth adding cross-references in doc-strings in both directions between move_left_lt and numeric.move_left_le (and similarly for move_right).

I remember finding this point confusing when learning about games, so the pointers to the "missing" lemmas might be helpful for a reader who is confused here.

@semorrison
Copy link
Collaborator

bors d+

@bors
Copy link

bors bot commented Apr 25, 2022

✌️ vihdzp can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Apr 25, 2022
@vihdzp
Copy link
Collaborator Author

vihdzp commented Apr 25, 2022

bors r+

@bors
Copy link

bors bot commented Apr 25, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(set_theory/game/pgame): x.move_left i < x and variants [Merged by Bors] - feat(set_theory/game/pgame): x.move_left i < x and variants Apr 25, 2022
@bors bors bot closed this Apr 25, 2022
@bors bors bot deleted the move_left_lt branch April 25, 2022 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants