[Merged by Bors] - chore(data/matrix): generalisation linter #13655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ericrbg
commented
Apr 24, 2022
ericrbg
commented
ericrbg
added
awaiting-CI
|
This is the remaining suggestions: /- The `generalisation_linter` linter reports: -/
/- typeclass generalisations may be possible -/
#check @matrix.neg_dot_product /- _inst_2: non_unital_non_assoc_ring ↝ add_comm_group has_distrib_neg has_mul
-/
#check @matrix.dot_product_neg /- _inst_2: non_unital_non_assoc_ring ↝ add_comm_group has_distrib_neg has_mul
-/
#check @matrix.star_dot_product_star /- _inst_3: star_ring ↝ has_star star_add_monoid star_semigroup
-/
#check @matrix.star_dot_product /- _inst_3: star_ring ↝ has_involutive_star star_add_monoid star_semigroup
-/
#check @matrix.dot_product_star /- _inst_3: star_ring ↝ has_involutive_star star_add_monoid star_semigroup
-/
#check @matrix.semiring.is_scalar_tower /- _inst_1: non_unital_non_assoc_semiring ↝ add_comm_monoid has_mul
-/
#check @matrix.semiring.smul_comm_class /- _inst_1: non_unital_non_assoc_semiring ↝ add_comm_monoid has_mul
-/
#check @matrix.mul_mul_right /- _inst_1: comm_semiring ↝ distrib_mul_action no_meet_fake_name semiring smul_comm_class
-/
#check @matrix.scalar.commute /- _inst_1: comm_semiring ↝ distrib_mul_action is_scalar_tower no_meet_fake_name semiring smul_comm_class
-/
#check @matrix.mul_vec_smul_assoc /- _inst_1: comm_semiring ↝ distrib_mul_action no_meet_fake_name semiring smul_comm_class
-/
#check @matrix.transpose_smul /- _inst_1: has_scalar ↝ has_scalar
-/
#check @matrix.conj_transpose_one /- _inst_3: star_ring ↝ has_star star_add_monoid star_semigroup
-/
#check @matrix.conj_transpose_mul /- _inst_3: star_ring ↝ has_star star_add_monoid star_semigroup
-/
#check @matrix.minor_smul /- _inst_1: has_scalar ↝ has_scalar
-/I felt hesitant to change the instances to not even have semirings in any way, because that seems like instance search problems. And the rest are just fake generalisations. |
github-actions
bot
removed
the
awaiting-CI
|
Thanks! |
github-actions
bot
added
ready-to-merge
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.