-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(analysis/*): a sample of easy useful lemmas #13697
Conversation
@@ -105,6 +105,9 @@ by simpa using cpow_neg x 1 | |||
complex.zero_cpow (nat.cast_ne_zero.2 (nat.succ_ne_zero _)), zero_mul] | |||
else by simp [cpow_add, hx, pow_add, cpow_nat_cast n] | |||
|
|||
@[simp] lemma cpow_two (x : ℂ) : x ^ (2 : ℂ) = x ^ 2 := |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these be tagged norm_cast
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no cast here (the 2
on the left is not the coercion from nat to complex, it is just the complex 2
), so norm_cast
does not work. On the other hand, there was a missing norm_cast
attribute on nearby lemmas!
src/analysis/normed/group/basic.lean
Outdated
@@ -1020,6 +1020,14 @@ begin | |||
exact (tendsto_at_top_of_eventually_const this).cauchy_seq.add hv | |||
end | |||
|
|||
lemma normed_group.tendsto_sub_nhds_zero_iff |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be closer to squeeze_zero_norm
and other filter
-norm
lemmas?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, because the proof uses the topological group instance which is proved just a few lines above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than the existing comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should generalise tendsto_sub_nhds_zero_iff
but otherwise this LGTM.
bors d+
src/analysis/normed/group/basic.lean
Outdated
@@ -1020,6 +1020,14 @@ begin | |||
exact (tendsto_at_top_of_eventually_const this).cauchy_seq.add hv | |||
end | |||
|
|||
lemma tendsto_sub_nhds_zero_iff |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we prove this for any topological group (multiplicative or additive) rather than just normed?
✌️ sgouezel can now approve this pull request. To approve and merge a pull request, simply reply with |
bors r+ |
Pull request successfully merged into master. Build succeeded: |
Lemmas needed for #13690