Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(order/well-founded): Remove redundant arguments #13702

Closed
wants to merge 1 commit into from

Conversation

vihdzp
Copy link
Collaborator

@vihdzp vihdzp commented Apr 25, 2022

All of these are inferred as {α : Type*} (as opposed to {α : Sort*}), and there is already a variables {α : Type*} at the top of the file.


Open in Gitpod

Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to note my confusion in the other PR: I assumed that these lemmas were implying {α : Sort*}, which would have made this a behavior change; but checking https://leanprover-community.github.io/mathlib_docs/order/well_founded.html confirms these were all inferred as Type* anyway.

bors d+

@bors
Copy link

bors bot commented Apr 25, 2022

✌️ vihdzp can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Apr 25, 2022
@eric-wieser eric-wieser added the awaiting-CI The author would like to see what CI has to say before doing more work. label Apr 25, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Apr 26, 2022
@vihdzp
Copy link
Collaborator Author

vihdzp commented Apr 26, 2022

bors r+

@bryangingechen bryangingechen changed the title feat(order/well-founded}: Remove redundant arguments feat(order/well-founded): Remove redundant arguments Apr 26, 2022
bors bot pushed a commit that referenced this pull request Apr 26, 2022
All of these are inferred as `{α : Type*}` (as opposed to `{α : Sort*}`), and there is already a `variables {α : Type*}` at the top of the file.
@bors
Copy link

bors bot commented Apr 26, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(order/well-founded): Remove redundant arguments [Merged by Bors] - feat(order/well-founded): Remove redundant arguments Apr 26, 2022
@bors bors bot closed this Apr 26, 2022
@bors bors bot deleted the remove_redundant_args branch April 26, 2022 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants