Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(logic/unit): Make punit.star simp normal form of default : punit #13741

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - feat(logic/unit): Make punit.star simp normal form of default : punit #13741

wants to merge 2 commits into from

Conversation

vihdzp
Copy link
Collaborator

@vihdzp vihdzp commented Apr 27, 2022

I'm expecting that this will make a few theorems no longer in normal form.

Open in Gitpod

@vihdzp vihdzp added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Apr 27, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Apr 27, 2022
eric-wieser
eric-wieser approved these changes Apr 27, 2022
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

Seems nothing was broken

bors bot pushed a commit that referenced this pull request Apr 27, 2022
@vihdzp
feat(logic/unit): Make punit.star simp normal form of `default : pu…
60bb071 
…nit` (#13741)
@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Apr 27, 2022
@bors
Copy link

bors bot commented Apr 27, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(logic/unit): Make punit.star simp normal form of default : punit [Merged by Bors] - feat(logic/unit): Make punit.star simp normal form of default : punit Apr 27, 2022
@bors bors bot closed this Apr 27, 2022
@bors bors bot deleted the default_eq branch April 27, 2022 23:46
@vihdzp vihdzp mentioned this pull request Apr 28, 2022
Closed
bors bot pushed a commit that referenced this pull request May 3, 2022
@vihdzp
feat(order/conditionally_complete_lattice): Simp theorems (#13756)
657632e 
We remove `supr_unit` and `infi_unit` since, thanks to #13741, they can be proven by `simp`.
bors bot pushed a commit that referenced this pull request May 3, 2022
@vihdzp
feat(order/conditionally_complete_lattice): Simp theorems (#13756)
fddabf2 
We remove `supr_unit` and `infi_unit` since, thanks to #13741, they can be proven by `simp`.
bors bot pushed a commit that referenced this pull request May 3, 2022
@vihdzp
feat(order/conditionally_complete_lattice): Simp theorems (#13756)
31a0776 
We remove `supr_unit` and `infi_unit` since, thanks to #13741, they can be proven by `simp`.
bors bot pushed a commit that referenced this pull request May 3, 2022
@vihdzp
feat(order/conditionally_complete_lattice): Simp theorems (#13756)
7931ba4 
We remove `supr_unit` and `infi_unit` since, thanks to #13741, they can be proven by `simp`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vihdzp @eric-wieser @leanprover-community-bot-assistant