[Merged by Bors] - feat(set_theory/game/pgame): Add missing basic API #13744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
vihdzp
commented
Apr 27, 2022
vihdzp
commented
vihdzp
added
the
awaiting-review
eric-wieser
reviewed
Apr 27, 2022
eric-wieser
reviewed
Apr 27, 2022
eric-wieser
reviewed
Apr 27, 2022
| @[simp] theorem half_left_moves : half.left_moves = punit := rfl | ||
| @[simp] theorem half_right_moves : half.right_moves = punit := rfl | ||
| @[simp] lemma half_move_left (x) : half.move_left x = 0 := rfl | ||
| @[simp] lemma half_move_right (x) : half.move_right x = 1 := rfl |
There was a problem hiding this comment.
I think it would be worth trying to train simps to generate these
There was a problem hiding this comment.
How does simps work?
There was a problem hiding this comment.
If pgame were a structure, rather than an inductive type, we would use initialize_simps_projections.
However as it is an inductive type I don't think we can do anything.
There was a problem hiding this comment.
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
semorrison
reviewed
Apr 28, 2022
semorrison
added
awaiting-author
vihdzp
added
awaiting-review
|
bors merge |
github-actions
bot
added
ready-to-merge
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.