Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(set_theory/surreal/basic): Allow dot notation on pgame.numeric #13768

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - chore(set_theory/surreal/basic): Allow dot notation on pgame.numeric #13768

wants to merge 2 commits into from

Conversation

YaelDillies
Copy link
Collaborator

Rename numeric_neg/numeric_add to numeric.add/numeric.neg. Prove numeric.sub in passing.

Open in Gitpod

@YaelDillies YaelDillies added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR labels Apr 28, 2022
@YaelDillies YaelDillies requested a review from vihdzp April 28, 2022 20:05
eric-wieser
eric-wieser approved these changes Apr 28, 2022
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

The variables statement is strange here, but the rest is a great idea

src/set_theory/surreal/basic.lean Outdated Show resolved Hide resolved
src/set_theory/surreal/basic.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Apr 28, 2022

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Apr 28, 2022
@YaelDillies @eric-wieser
inline variables
6f96b95 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@YaelDillies
Copy link
Collaborator Author

bors merge

vihdzp
vihdzp approved these changes Apr 28, 2022
View reviewed changes
Copy link
Collaborator

@vihdzp vihdzp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like I'm too late, but I approve of this!

bors bot pushed a commit that referenced this pull request Apr 28, 2022
@YaelDillies
chore(set_theory/surreal/basic): Allow dot notation on pgame.numeric (
214e2f1 
#13768)

Rename `numeric_neg`/`numeric_add` to `numeric.add`/`numeric.neg`. Prove `numeric.sub` in passing.
@bors
Copy link

bors bot commented Apr 28, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(set_theory/surreal/basic): Allow dot notation on pgame.numeric [Merged by Bors] - chore(set_theory/surreal/basic): Allow dot notation on pgame.numeric Apr 28, 2022
@bors bors bot closed this Apr 28, 2022
@bors bors bot deleted the numeric_sub branch April 28, 2022 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

@vihdzp vihdzp vihdzp approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. easy < 20s of review time. See the lifecycle page for guidelines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@YaelDillies @eric-wieser @vihdzp @leanprover-community-bot-assistant