Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(linear_algebra/finite_dimensional): of_injective #13792

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - feat(linear_algebra/finite_dimensional): of_injective #13792

wants to merge 4 commits into from

Conversation

semorrison
Copy link
Collaborator

Open in Gitpod

@semorrison semorrison mentioned this pull request Apr 29, 2022
Closed
3 tasks
eric-wieser
eric-wieser reviewed Apr 29, 2022
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use this new lemma to clean up the lemma I pointed out on Zulip?

@semorrison semorrison mentioned this pull request Apr 29, 2022
Closed
1 task
@semorrison semorrison added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Apr 29, 2022
semorrison and others added 2 commits April 30, 2022 11:02
@semorrison @alreadydone
Update src/linear_algebra/finite_dimensional.lean
f05487c 
Co-authored-by: Junyan Xu <junyanxumath@gmail.com>
@semorrison
lint
2263e6e
@semorrison semorrison removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Apr 30, 2022
alreadydone
alreadydone approved these changes May 1, 2022
View reviewed changes
Copy link
Collaborator

@alreadydone alreadydone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

jcommelin
jcommelin approved these changes May 2, 2022
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels May 2, 2022
bors bot pushed a commit that referenced this pull request May 2, 2022
@semorrison
feat(linear_algebra/finite_dimensional): of_injective (#13792)
90b1ddb 


Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented May 2, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(linear_algebra/finite_dimensional): of_injective [Merged by Bors] - feat(linear_algebra/finite_dimensional): of_injective May 2, 2022
@bors bors bot closed this May 2, 2022
@bors bors bot deleted the semorrison/finite_dimensional_of_injective branch May 2, 2022 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

@alreadydone alreadydone alreadydone approved these changes

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@semorrison @eric-wieser @alreadydone @jcommelin @leanprover-community-bot-assistant