Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(set_theory/surreal/basic): Inline instances #13811

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - chore(set_theory/surreal/basic): Inline instances #13811

wants to merge 1 commit into from

Conversation

vihdzp
Copy link
Collaborator

@vihdzp vihdzp commented Apr 29, 2022

We inline various definitions used only for instances. We also remove the redundant lemma not_le (which is more generally true on preorders).

Open in Gitpod

@vihdzp vihdzp added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR labels Apr 29, 2022
eric-wieser
eric-wieser approved these changes May 1, 2022
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

Thanks!

It would be nice to have some API lemmas in this file relating these operators to mk; this inlining makes unfolding even more awkward than it already was. Either way, that doesn't need to be in this PR.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels May 1, 2022
bors bot pushed a commit that referenced this pull request May 1, 2022
@vihdzp
chore(set_theory/surreal/basic): Inline instances (#13811)
b236cb2 
We inline various definitions used only for instances. We also remove the redundant lemma `not_le` (which is more generally true on preorders).
@bors
Copy link

bors bot commented May 1, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(set_theory/surreal/basic): Inline instances [Merged by Bors] - chore(set_theory/surreal/basic): Inline instances May 1, 2022
@bors bors bot closed this May 1, 2022
@bors bors bot deleted the inline_instances branch May 1, 2022 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vihdzp @eric-wieser @leanprover-community-bot-assistant