Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(logic/function/basic): don't unfold set in cantor #13822

Closed
wants to merge 1 commit into from

Conversation

digama0
Copy link
Member

@digama0 digama0 commented Apr 30, 2022

This uses set_of and mem consistently instead of using application everywhere, since f has type A -> set A instead of A -> A -> Prop. (Arguably, it could just be stated for A -> A -> Prop instead though.)

@vihdzp
Copy link
Collaborator

vihdzp commented Apr 30, 2022

I think this counts as a chore rather than a refactor, since no external API was changed.

@eric-wieser
Copy link
Member

bors d+

Consider changing the commit prefix, I agree with @vihdzp that chore is probably better

@bors
Copy link

bors bot commented May 1, 2022

✌️ digama0 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added the delegated The PR author may merge after reviewing final suggestions. label May 1, 2022
@digama0 digama0 changed the title refactor(logic/function/basic): don't unfold set in cantor chore(logic/function/basic): don't unfold set in cantor May 2, 2022
@digama0
Copy link
Member Author

digama0 commented May 2, 2022

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label May 2, 2022
bors bot pushed a commit that referenced this pull request May 2, 2022
This uses `set_of` and `mem` consistently instead of using application everywhere, since `f` has type `A -> set A` instead of `A -> A -> Prop`. (Arguably, it could just be stated for `A -> A -> Prop` instead though.)
@bors
Copy link

bors bot commented May 2, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(logic/function/basic): don't unfold set in cantor [Merged by Bors] - chore(logic/function/basic): don't unfold set in cantor May 2, 2022
@bors bors bot closed this May 2, 2022
@bors bors bot deleted the cantor_set_notation branch May 2, 2022 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants