Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - fix(algebra/indicator_function): add missing decidable instances to lemma statements #13834

Closed
wants to merge 9 commits into from
Closed

[Merged by Bors] - fix(algebra/indicator_function): add missing decidable instances to lemma statements #13834

wants to merge 9 commits into from

Conversation

eric-wieser
Copy link
Member

This keeps the definition of set.indicator as non-computable, but ensures that when lemmas are applied they generalize to any decidable instances.

Open in Gitpod

@eric-wieser
fix(algebra/indicator_function): add missing decidable instances to l…
b6bcf10 
…emma statements

This keeps the definition of `set.indicator` as non-computable, but ensures that when lemmas are applied they generalize to any decidable instances.
@eric-wieser
comment
bc25cfb
@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Apr 30, 2022
@eric-wieser eric-wieser requested review from JasonKYi and removed request for JasonKYi April 30, 2022 16:14
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Apr 30, 2022
@eric-wieser eric-wieser requested a review from urkud May 1, 2022 21:45
jcommelin
jcommelin approved these changes May 2, 2022
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels May 2, 2022
@bryangingechen
Copy link
Collaborator

bors crashed
bors r+

bors bot pushed a commit that referenced this pull request May 2, 2022
@eric-wieser
fix(algebra/indicator_function): add missing decidable instances to l…
4fe734d 
…emma statements (#13834)

This keeps the definition of `set.indicator` as non-computable, but ensures that when lemmas are applied they generalize to any decidable instances.
@bors
Copy link

bors bot commented May 2, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title fix(algebra/indicator_function): add missing decidable instances to lemma statements [Merged by Bors] - fix(algebra/indicator_function): add missing decidable instances to lemma statements May 2, 2022
@bors bors bot closed this May 2, 2022
@bors bors bot deleted the eric-wieser/indicator-decidable branch May 2, 2022 15:57
@ocfnash
Copy link
Collaborator

ocfnash commented May 11, 2022

Just seeing this now: thank you for doing this!

I kept trying to find time to get round to doing this but never did.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

@urkud urkud Awaiting requested review from urkud

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@eric-wieser @bryangingechen @ocfnash @jcommelin @leanprover-community-bot-assistant