Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(order/*): Replace total partial orders by linear orders #13839

Closed
wants to merge 10 commits into from
Closed

[Merged by Bors] - chore(order/*): Replace total partial orders by linear orders #13839

wants to merge 10 commits into from

Conversation

YaelDillies
Copy link
Collaborator

@YaelDillies YaelDillies commented Apr 30, 2022 •
edited

partial_order α + is_total α (≤) has no more theorems than linear_order α but is nonetheless used in some places. This replaces those uses by linear_order α or complete_linear_order α. Also make implicit one argument of finset.lt_inf'_iff and friends.

Open in Gitpod

@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Apr 30, 2022
@YaelDillies YaelDillies mentioned this pull request May 1, 2022
Closed
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label May 2, 2022
YaelDillies referenced this pull request May 2, 2022
@YaelDillies
revert improvements
994ce23
jcommelin
jcommelin approved these changes May 3, 2022
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels May 3, 2022
bors bot pushed a commit that referenced this pull request May 3, 2022
@YaelDillies
chore(order/*): Replace total partial orders by linear orders (#13839)
e104992 
`partial_order α` + `is_total α (≤)` has no more theorems than `linear_order α`  but is nonetheless used in some places. This replaces those uses by `linear_order α` or `complete_linear_order α`. Also make implicit one argument of `finset.lt_inf'_iff` and friends.
@bors
Copy link

bors bot commented May 3, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(order/*): Replace total partial orders by linear orders [Merged by Bors] - chore(order/*): Replace total partial orders by linear orders May 3, 2022
@bors bors bot closed this May 3, 2022
@bors bors bot deleted the kill_is_total branch May 3, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@YaelDillies @jcommelin @leanprover-community-bot-assistant