Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(category_theory/Fintype): equiv_equiv_iso #13984

Closed
wants to merge 15 commits into from
Closed

[Merged by Bors] - feat(category_theory/Fintype): equiv_equiv_iso #13984

wants to merge 15 commits into from

Conversation

semorrison
Copy link
Collaborator

@semorrison semorrison commented May 6, 2022 •
edited by github-actions bot

@semorrison semorrison added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels May 6, 2022
@mathlib-dependent-issues-bot mathlib-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label May 6, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label May 7, 2022
@mathlib-dependent-issues-bot mathlib-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label May 14, 2022
@mathlib-dependent-issues-bot
Copy link
Collaborator

This PR/issue depends on:

@urkud
Copy link
Member

urkud commented May 22, 2022

Could you please explain other changes? I see that you reorder imports and add a new file.

@urkud urkud added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels May 22, 2022
@semorrison
Copy link
Collaborator Author

Could you please explain other changes? I see that you reorder imports and add a new file.

Sorry, @urkud, I hadn't merged master so the diffs were very misleading! Hopefully it is easier to review now.

@semorrison semorrison added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. and removed awaiting-author A reviewer has asked the author a question or requested changes labels May 22, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label May 23, 2022
@urkud
Copy link
Member

urkud commented Jun 12, 2022

Thanks!
bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jun 12, 2022
bors bot pushed a commit that referenced this pull request Jun 12, 2022
@semorrison
feat(category_theory/Fintype): equiv_equiv_iso (#13984)
eb063e7 
From LTE.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented Jun 12, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(category_theory/Fintype): equiv_equiv_iso [Merged by Bors] - feat(category_theory/Fintype): equiv_equiv_iso Jun 12, 2022
@bors bors bot closed this Jun 12, 2022
@bors bors bot deleted the semorrison/Fintype-equiv-equiv-iso branch June 12, 2022 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@semorrison @mathlib-dependent-issues-bot @urkud