Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(analysis/normed_space/exponential): Make the 𝔸 argument implicit #13986

Closed
wants to merge 2 commits into from

Conversation

eric-wieser
Copy link
Member

exp 𝕂 𝔸 is now just exp 𝕂.

This also renames two lemmas that refer to this argument in their name to no longer do so.

In a few places we have to add type annotations where they weren't needed before, but nowhere do we need to resort to @.


Open in Gitpod

@eric-wieser eric-wieser added the awaiting-review The author would like community review of the PR label May 6, 2022
@eric-wieser eric-wieser requested a review from ADedecker May 6, 2022 12:17
@ADedecker
Copy link
Member

I originally wanted to keep it explicit because it felt weird to have exp 𝕂 not mean exp : 𝕂 \to 𝕂, so always having both arguments seemed like it would avoid confusion. But that just seems to be annoying everyone using it, and I agree that since it always come either with a type annotation or applied to a known-type argument, it's not as confusing as I thought it would be, so I fully support making it implicit.

Co-authored-by: Julian Berman <Julian@GrayVines.com>
@dupuisf
Copy link
Collaborator

dupuisf commented May 6, 2022

Looks good!

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels May 6, 2022
bors bot pushed a commit that referenced this pull request May 6, 2022
…cit (#13986)

`exp 𝕂 𝔸` is now just `exp 𝕂`.

This also renames two lemmas that refer to this argument in their name to no longer do so.

In a few places we have to add type annotations where they weren't needed before, but nowhere do we need to resort to `@`.
@bors
Copy link

bors bot commented May 6, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(analysis/normed_space/exponential): Make the 𝔸 argument implicit [Merged by Bors] - chore(analysis/normed_space/exponential): Make the 𝔸 argument implicit May 6, 2022
@bors bors bot closed this May 6, 2022
@bors bors bot deleted the eric-wieser/exp-implicit branch May 6, 2022 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants