Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(ring_theory/localization): generalize lemmas from comm_ring to comm_semiring #13994

Closed
wants to merge 5 commits into from

Conversation

yuma-mizuno
Copy link
Collaborator

@yuma-mizuno yuma-mizuno commented May 6, 2022

This PR does not add new stuffs, but removes several subtractions from the proofs.


Open in Gitpod

@yuma-mizuno yuma-mizuno added the awaiting-review The author would like community review of the PR label May 6, 2022
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels May 6, 2022
bors bot pushed a commit that referenced this pull request May 6, 2022
… `comm_semiring` (#13994)

This PR does not add new stuffs, but removes several subtractions from the proofs.
@bors
Copy link

bors bot commented May 6, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(ring_theory/localization): generalize lemmas from comm_ring to comm_semiring [Merged by Bors] - feat(ring_theory/localization): generalize lemmas from comm_ring to comm_semiring May 6, 2022
@bors bors bot closed this May 6, 2022
@bors bors bot deleted the ymizuno/localization branch May 6, 2022 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants