Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(algebra/algebra/restrict_scalars): put a right action on restricted scalars #13996

Closed
wants to merge 4 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented May 6, 2022

This provides module Rᵐᵒᵖ (restrict_scalars R S M) in terms of a module Sᵐᵒᵖ M action, by sending Rᵐᵒᵖ to Sᵐᵒᵖ through algebra_map R S.

This means that restrict_scalars R S M now works for right-modules and bi-modules in addition to left-modules.

This will become important if we change algebra R A to require A to be an R-bimodule, as otherwise restrict_scalars R S A would no longer be an algebra.

Zulip


Open in Gitpod

@semorrison semorrison added the awaiting-review The author would like community review of the PR label May 7, 2022
Comment on lines +113 to +117
instance restrict_scalars.op_module [module Sᵐᵒᵖ M] : module Rᵐᵒᵖ (restrict_scalars R S M) :=
begin
letI : module Sᵐᵒᵖ (restrict_scalars R S M) := ‹module Sᵐᵒᵖ M›,
exact module.comp_hom M (algebra_map R S).op
end
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I am surprised by this one!

If something happens to have both an S and an Smop action, why would restricting scalars for the S action also restrict the Smop action? In particular, a common application in my mind (from the theory of subfactors) is an inclusion of algebras A into B naturally giving us the A-B bimodule B. (Where we start with B as a B-B bimodule, and then restrict the left action.)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have said that if you have commuting actions on the original module of any two rings, and you restrict one of them, you still have a commuting action with the other ring. (In fact, when I read the title and PR description this is what I was expecting to see.)

Copy link
Member Author

@eric-wieser eric-wieser May 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The motivation for this is #10716, where I need both a left and right action in order for restrict_scalars S R A to be considered an S-algebra. This comes up immediately; restrict_scalars.lsmul : S →ₐ[R] module.End R (restrict_scalars R S M) only makes sense if (restrict_scalars R S M) is a bimodule, as otherwise module.End.algebra can't exist.

I would have said that if you have commuting actions on the original module of any two rings, and you restrict one of them, you still have a commuting action with the other ring.

Sure, but we can't even state the actions commute without first copying them across; and we can't copy across all of them, as:

  • This would create diamonds if M already has an S-action
  • This would entail copying across the R-action on M which you just removed.

Copy link
Collaborator

@semorrison semorrison May 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussion continued on zulip.

@semorrison semorrison added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels May 7, 2022
@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels May 7, 2022
@ocfnash
Copy link
Collaborator

ocfnash commented May 31, 2022

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels May 31, 2022
bors bot pushed a commit that referenced this pull request May 31, 2022
…cted scalars (#13996)

This provides `module Rᵐᵒᵖ (restrict_scalars R S M)` in terms of a `module Sᵐᵒᵖ M` action, by sending `Rᵐᵒᵖ` to `Sᵐᵒᵖ` through `algebra_map R S`.

This means that `restrict_scalars R S M` now works for right-modules and bi-modules in addition to left-modules.

This will become important if we change `algebra R A` to require `A` to be an `R`-bimodule, as otherwise `restrict_scalars R S A` would no longer be an algebra.

[Zulip](https://leanprover.zulipchat.com/#narrow/stream/144837-PR-reviews/topic/.2313996.20right.20actions.20on.20restrict_scalars/near/282045994)
@bors
Copy link

bors bot commented May 31, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(algebra/algebra/restrict_scalars): put a right action on restricted scalars [Merged by Bors] - chore(algebra/algebra/restrict_scalars): put a right action on restricted scalars May 31, 2022
@bors bors bot closed this May 31, 2022
@bors bors bot deleted the eric-wieser/restrict_scalars-right_action branch May 31, 2022 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants