Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(order/*): Less order_dual abuse #14008

Closed
wants to merge 5 commits into from

Conversation

YaelDillies
Copy link
Collaborator

Sanitize uses of order_dual by inserting the required of_dual and to_dual instead of type-ascripting. Also remove some uses which were not necessary. Those dated from the time where we did not have antitone functions.


Open in Gitpod

@YaelDillies YaelDillies added the awaiting-review The author would like community review of the PR label May 7, 2022
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, thanks!

@eric-wieser eric-wieser added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels May 7, 2022
@bors
Copy link

bors bot commented May 7, 2022

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the delegated The PR author may merge after reviewing final suggestions. label May 7, 2022
@YaelDillies
Copy link
Collaborator Author

bors merge

bors bot pushed a commit that referenced this pull request May 7, 2022
Sanitize uses of `order_dual` by inserting the required `of_dual` and `to_dual` instead of type-ascripting. Also remove some uses which were not necessary. Those dated from the time where we did not have antitone functions.
@bors
Copy link

bors bot commented May 7, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(order/*): Less order_dual abuse [Merged by Bors] - chore(order/*): Less order_dual abuse May 7, 2022
@bors bors bot closed this May 7, 2022
@bors bors bot deleted the less_order_dual branch May 7, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-author A reviewer has asked the author a question or requested changes delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants